Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit split for string keywords #96

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Limit split for string keywords #96

merged 4 commits into from
Oct 3, 2023

Conversation

Hotdawg
Copy link
Contributor

@Hotdawg Hotdawg commented Sep 18, 2023

Fixes #95

There are probably other places where limiting split makes sense (e.g. arrayKeywords), but this PR focuses on the pattern keyword specifically.

samlown
samlown requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! looks good, just a Linter issue to fix before we can merge.

@Hotdawg
Copy link
Contributor Author

Hotdawg commented Sep 29, 2023

Should be fixed now

@Hotdawg Hotdawg requested a review from samlown October 2, 2023 08:47
samlown
samlown approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

@samlown
Copy link
Contributor

samlown commented Oct 2, 2023

Sorry @Hotdawg, looks like the tests are failing now :-(

@Hotdawg
Copy link
Contributor Author

Hotdawg commented Oct 3, 2023

Updated the branch with latest, Fixed failing tests.
tests and linter passes on my machine

@Hotdawg Hotdawg requested a review from samlown October 3, 2023 00:31
@samlown samlown merged commit cada51d into invopop:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlown samlown Awaiting requested review from samlown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pattern keyword do not appear when = character is in regex
2 participants
@Hotdawg @samlown